Update TORCH_CUDA_VERSION usage #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laggui
requested review from
louisfd,
nathanielsimard,
antimora and
syl20bnr
and removed request for
louisfd and
nathanielsimard
syl20bnr
approved these changes
Feb 9, 2024
nathanielsimard
approved these changes
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
While making changes to move
download_file_as_bytestoburn-commonI stumbled upon the multiple instructions to setTORCH_CUDA_VERSIONto a version that is no longer supported by the currenttchcrate.Changed all instructions to set
TORCH_CUDA_VERSION=cu121(latest and current supported CUDA version for libtorch/tch).