Fix wgpu performance issue: revert to wgpu 0.18.0 #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syl20bnr
approved these changes
Feb 1, 2024
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1221 /- ##
==========================================
- Coverage 84.42% 84.42% -0.01%
==========================================
Files 549 549
Lines 61921 61920 -1
==========================================
- Hits 52278 52277 -1
Misses 9643 9643 ☔ View full report in Codecov by Sentry. |
syl20bnr
pushed a commit
that referenced
this pull request
Feb 1, 2024
* Use wgpu 0.18.0 * Fix clippy
syl20bnr
pushed a commit
that referenced
this pull request
Feb 1, 2024
* Use wgpu 0.18.0 * Fix clippy
syl20bnr
pushed a commit
that referenced
this pull request
Feb 1, 2024
* Use wgpu 0.18.0 * Fix clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that the new wgpu release has introduced a significant performance issue.
I conducted some benchmarks by training a transformer for 1 epoch on the
ag-newsdataset using thetext-classificationexample:fix: 3m5.907sv0.11.1: 4m22.933sv0.12.0: after 3 minutes, only 34% completed (66% remaining)All benchmarks were performed on Pop OS with an Nvidia 3070. The backend in use was
Fusion<Wgpu>.We plan to incorporate more automated benchmarks in the future to proactively identify and address performance regressions like this one.
Fix #1213