Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regex fix pytorch #1196

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Regex fix pytorch #1196

merged 2 commits into from
Jan 31, 2024

Conversation

antimora
Copy link
Collaborator

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

#1085

Changes

  • Remove ^ and $ regex wrapping per user's request:

I don't think it's a good idea to insert ^ and $ in this place, it will mislead the user.
And there are many use cases where ^ and $ need to be removed. For example I tried to rename all keys like conv.0 to conv0 because I used some workaround to implement PyTorch's Sequential in Burn. I want to do this for the whole model, it would be convenient if I could use .with_key_remap(r#"([a-z] )\.(\d )"#, "$1$2").

Testing

Unit testing and run-checks all.

This was referenced Jan 30, 2024
Merged
Merged
@antimora
Copy link
Collaborator Author

I filed a ticket with hoot library which is breaking our CI: algesten/hoot#1

@codecov Codecov
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b7486b0) 84.47% compared to head (2ee8484) 84.47%.
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1196    /-   ##
=======================================
  Coverage   84.47%   84.47%           
=======================================
  Files         548      548           
  Lines       61808    61808           
=======================================
  Hits        52213    52213           
  Misses       9595     9595

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nathanielsimard nathanielsimard merged commit 14aad24 into tracel-ai:main Jan 31, 2024
14 checks passed
@nathanielsimard nathanielsimard deleted the regex-fix-pytorch branch January 31, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanielsimard nathanielsimard nathanielsimard approved these changes

@ashdtu ashdtu Awaiting requested review from ashdtu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antimora @nathanielsimard