Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example/regression #1150

Merged
merged 6 commits into from
Jan 20, 2024
Merged

Example/regression #1150

merged 6 commits into from
Jan 20, 2024

Conversation

ashdtu
Copy link
Contributor

@ashdtu ashdtu commented Jan 18, 2024 •
edited
Loading

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

#1148

Changes

Create an example to demonstrate how to do Regression problem using Burn framework. The example uses Toy-diabetes dataset present as a standard dataset in sklearn datasets. The dataset is also available for download from Hugging Face hub dataset.

Testing

  • The dataset was split into train/test split and the MSE Loss for both splits were logged. No overfitting in the given model.
  • ./run-checks.sh all was executed to check for compilation validity in example. No separate unit tests written.

nathanielsimard
nathanielsimard requested changes Jan 18, 2024
View reviewed changes
Copy link
Member

@nathanielsimard nathanielsimard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got some minor comments, but good job 👏

examples/simple-regression/src/dataset.rs Outdated Show resolved Hide resolved
examples/simple-regression/src/dataset.rs Outdated Show resolved Hide resolved
examples/simple-regression/src/dataset.rs Outdated Show resolved Hide resolved
examples/simple-regression/src/dataset.rs Outdated Show resolved Hide resolved
examples/simple-regression/src/model.rs Outdated Show resolved Hide resolved
examples/simple-regression/src/model.rs Outdated Show resolved Hide resolved
examples/simple-regression/src/model.rs Outdated Show resolved Hide resolved
examples/simple-regression/src/training.rs Show resolved Hide resolved
examples/simple-regression/src/training.rs Outdated Show resolved Hide resolved
@ashdtu
Copy link
Contributor Author

ashdtu commented Jan 18, 2024

Hi, made all changes suggested in latest commit.

@codecov Codecov
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0a85744) 85.82% compared to head (ee2651c) 86.04%.
Report is 6 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1150       /-   ##
==========================================
  Coverage   85.82%   86.04%    0.21%     
==========================================
  Files         516      521        5     
  Lines       57215    58289     1074     
==========================================
  Hits        49105    50153     1048     
- Misses       8110     8136       26

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nathanielsimard
nathanielsimard approved these changes Jan 20, 2024
View reviewed changes
Copy link
Member

@nathanielsimard nathanielsimard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean, good job! 👏

@nathanielsimard nathanielsimard merged commit e335552 into main Jan 20, 2024
15 checks passed
@nathanielsimard nathanielsimard deleted the example/regression branch January 20, 2024 02:28
@ashdtu ashdtu mentioned this pull request Jan 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanielsimard nathanielsimard nathanielsimard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ashdtu @nathanielsimard