Feat/wgpu/repeat #1068
Merged
Feat/wgpu/repeat #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1068 /- ##
==========================================
Coverage 85.54% 85.59% 0.04%
==========================================
Files 508 509 1
Lines 54019 54161 142
==========================================
Hits 46211 46357 146
Misses 7808 7804 -4 ☔ View full report in Codecov by Sentry. |
nathanielsimard
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
run-checks allscript has been executed.Related Issues/PRs
In #1049 Repeat was a bottleneck
Changes
Made a wgpu kernel for repeat operation, so we don't need to call many slice_assign kernels
Testing
Tests for the kernel in several dims, a larger one that exceeds the workgroup size, and tests for int and bool versions.