Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate MNIST Dataset to not use Python #1157

Closed
louisfd opened this issue Jan 19, 2024 · 1 comment · Fixed by #1176
Closed

Migrate MNIST Dataset to not use Python #1157

louisfd opened this issue Jan 19, 2024 · 1 comment · Fixed by #1176
Assignees
@laggui
Labels
accessibility Everything that is related to making Burn more accessible documentation Improvements or additions to documentation
Milestone
Release 0.12.0

Comments

@louisfd
Copy link
Member

louisfd commented Jan 19, 2024

Be able to download MNIST dataset without needing Python.
Use HF Rust bindings for this specific dataset: #1027
Change the book to not have to install python at the beginning.
@louisfd louisfd added documentation Improvements or additions to documentation accessibility Everything that is related to making Burn more accessible labels Jan 19, 2024
@nathanielsimard nathanielsimard added this to the Release 0.12.0 milestone Jan 22, 2024
@laggui
Copy link
Member

laggui commented Jan 24, 2024

As discussed in the other issue, turns out MNIST is a great example of a HF hub dataset that only relies on their python config file for the datasets library to correctly download and setup the data.

https://huggingface.co/datasets/mnist/blob/main/mnist.py

The hf-hub crate is not going to be useful here. The only files available to download in that repo is the python config that will need to be parsed in order to actually download and setup the data.

I'll just use the same data source as their config to download the files, but this won't require the use of the hf-hub crate.

@laggui laggui mentioned this issue Jan 25, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laggui laggui

Labels
accessibility Everything that is related to making Burn more accessible documentation Improvements or additions to documentation
Projects
Burn 🔥
Status: Done
Milestone
Release 0.12.0
Development

Successfully merging a pull request may close this issue.

Add vision/mnist dataset tracel-ai/burn
3 participants
@laggui @louisfd @nathanielsimard