Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add link to Day.js format reference #1506

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Add link to Day.js format reference #1506

merged 1 commit into from
Jun 27, 2024

Conversation

DarkFox
Copy link
Contributor

@DarkFox DarkFox commented Jun 27, 2024

Proposed Change

Add a link to the Day.js Format docs page to the eventDateFormat field in the documentation.

Related issues

Fixes #1505

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (build / ci etc.)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@sourcery-ai Sourcery AI
Copy link

sourcery-ai bot commented Jun 27, 2024 •
edited
Loading

🧙 Sourcery has finished reviewing your pull request!

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

sourcery-ai[bot]
sourcery-ai bot reviewed Jun 27, 2024
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@marksie1988 marksie1988 merged commit 76252ea into totaldebug:master Jun 27, 2024
1 of 2 checks passed
@marksie1988
Copy link
Collaborator

Thanks, that has now been merged

@DarkFox DarkFox deleted the patch-1 branch June 27, 2024 09:38
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 7, 2024

🎉 This PR is included in version 10.0.1-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai Sourcery AI Sourcery AI left review comments

Assignees
No one assigned
Labels
released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation for how to use eventDateFormat is difficult to find
2 participants
@DarkFox @marksie1988