Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an optional flag to export circuit id per port #2136

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ppopth
Copy link
Contributor

@ppopth ppopth commented Dec 16, 2021

Previously we have HiddenServiceExportCircuitID which allows us to
export the circuit id using haproxy. However, such directive is applied
globally in the service. We need a way to export the circuit id only for
some virtual ports.

We can do that by adding an optional flag to the HiddenServicePort
directive to specify that we will export the circuit id for such port.
The flag in HiddenServicePort will override the one in
HiddenServiceExportCircuitID, if it's not none. But it will use the
protocol specified in HiddenServiceExportCircuitID, if it's otherwise.

So, the new syntax for HiddenServicePort directive will be
HiddenServicePort VIRTPORT [TARGET [EXPORT-CIRCUIT-ID-PROTOCOL]]

Previously we have HiddenServiceExportCircuitID which allows us to
export the circuit id using haproxy. However, such directive is applied
globally in the service. We need a way to export the circuit id only for
some virtual ports.

We can do that by adding an optional flag to the HiddenServicePort
directive to specify that we will export the circuit id for such port.
The flag in HiddenServicePort will override the one in
HiddenServiceExportCircuitID, if it's not none. But it will use the
protocol specified in HiddenServiceExportCircuitID, if it's otherwise.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants