Better focus in column mode #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When scrolling down we need to switch to valign=bottom to properly show last lines of the TodoWidget at the end of the TodoListWidget. Also config <Down> key to use 'down' action in default config. Without such config entry, using <Down> key would not take advantage of valign fix. Also do not focus dividers when jumping with 'home' shortcut.
Previously there wasn't any indicator of focus for empty columns. Now title widget is highlighted then. Color is the same as for TodoWidget focus and already configured by 'focus_background_color'.
Codecov Report
@@ Coverage Diff @@
## master #281 /- ##
=======================================
Coverage 97.08% 97.08%
=======================================
Files 51 51
Lines 2950 2950
Branches 457 457
=======================================
Hits 2864 2864
Misses 61 61
Partials 25 25
Continue to review full report at Codecov.
|
|
FYI, I plan on releasing before the end of the year. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 3 things:
homeaction is executed and stops there. Previously it focused on divider between first task and title widget.