Update fpm manifest to enforce module naming #121
Conversation
|
Will merging this break all fpm builds with existing fpm versions? So we best have to wait for a new fpm release before applying this change. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #121 /- ##
=======================================
Coverage 65.95% 65.95%
=======================================
Files 29 29
Lines 3169 3169
Branches 1350 1350
=======================================
Hits 2090 2090
Misses 393 393
Partials 686 686 ☔ View full report in Codecov by Sentry. |
|
As far as I can tell, having the |
That is not true for any version of fpm due to the allowed keyword checks in https://github.com/fortran-lang/fpm/blob/main/src/fpm/manifest/build.f90#L119 |
|
Wow, this is a pretty severe limitation. But, the current fpm build points to a given commit. I guess we should look at how far backward this was prescribed. |
|
Fpm would be fine with a pinned commit, but merging this patch would break TOML Fortran for everyone else using the latest version with fpm, so this is not acceptable at the moment. |
|
Yes I agree the major improvements planned on fpm will break many things. Let's leave this PR here for when the time comes. |
This commit adds a suitable `module-naming` convention to the fpm manifest for toml-f. Because toml-f already enforces a valid unique naming (`module tomlf_*`), there is no need to modify any of the source files. The current commit explicitly adds the naming convention in place to the manifest. When module names become enforced by default in fpm, this flag will be necessary to build fpm from fpm.
awvwgk
force-pushed
the
enforce_module_names
branch
from
273609b
to
2c42dd9
Compare
This commit adds a suitable
module-namingconvention to the fpm manifest for toml-f. Because toml-f already enforces a valid unique naming (module tomlf_*), there is no need to modify any of the source files. The current commit explicitly adds the naming convention in place to the manifest.When module names become enforced by default in fpm, this flag will be necessary to build fpm from fpm.