Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add building with nuitka #20

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Add building with nuitka #20

merged 1 commit into from
Aug 12, 2021

Conversation

Eeems
Copy link
Member

@Eeems Eeems commented Aug 1, 2021

Fix #19

@Eeems Eeems added the enhancement New feature or request label Aug 1, 2021
@Eeems Eeems requested a review from matteodelabre August 1, 2021 20:56
@Eeems Eeems mentioned this pull request Aug 1, 2021
@matteodelabre
Copy link
Member

Thanks for the PR! I rebased it and changed the following things in the Makefile: 

  1. Moved the virtual env directory to a hidden directory.
  2. Instead of making targets depend on setup, I made them depend on .venv/bin/activate, so that the virtual env creation and pip install code only runs if the virtual env is missing.
  3. Made nuitka use an icon in the project repository instead of a system-dependent path.
  4. Removed the deactivate logic in targets: there’s no need to cleanup after activating the virtual env since each shell command of the Makefile get executed in a different subprocess anyway.

Hope that is ok. If so, I think this can be merged!

@Eeems
Copy link
Member Author

Eeems commented Aug 12, 2021

Looks good to me! I"ll merge it!

@Eeems Eeems merged commit c7891f2 into main Aug 12, 2021
@Eeems Eeems deleted the nuitka branch August 12, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compile into single executable
2 participants