Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange behaviour on pushing changes: Diff actual pushed changes #3028

Closed
rbosker opened this issue Jul 25, 2024 · 6 comments · Fixed by #3035
Closed

Strange behaviour on pushing changes: Diff actual pushed changes #3028

rbosker opened this issue Jul 25, 2024 · 6 comments · Fixed by #3035
Assignees
Labels
2.0-rc10 bug Something isn't working plugin v2 variables, UI, WTCG format, Bitbucket

Comments

@rbosker
Copy link
Collaborator

rbosker commented Jul 25, 2024

Describe the bug
There are 2 issues that seems to be somewhat related:

  1. Diff view on push shows tokens that are already pushed (this doesn't work in beta releases, but does work in 1.38.9)
  2. Pushing tokens making strange commits (changing not only the token that you added/edited)

Please check the screenrecording where I explain what the issue is:

Screen.Recording.2024-07-25.at.12.27.47.mov
@cuserox
Copy link
Contributor

cuserox commented Jul 30, 2024

I believe we have a fix 🔨 ✨ The last up to date build can be found here: #3035 (comment)

@rbosker could you please give it a test, and note down if:

  • Is the original issue fixed?
  • Any other unexpected behaviours?

Thanks! 😄

@rbosker
Copy link
Collaborator Author

rbosker commented Jul 30, 2024

@cuserox

  1. Diff view is fixed and didn't see any strange behaviour over there 🎈
  2. The pushes still seems inconsistent as we noticed last week. If you make 2 commits to the same branch in a short amount of time, could it be that GitHub merges those 2 commits into one? That seems to be happening.

@rbosker
Copy link
Collaborator Author

rbosker commented Jul 30, 2024

One thing I noticed besides this: this build (and the previous one you shared) doesn't accept my license key. I think this is due to the build, since in all RC's this does work properly.

@cuserox
Copy link
Contributor

cuserox commented Jul 30, 2024

2. The pushes still seems inconsistent as we noticed last week. If you make 2 commits to the same branch in a short amount of time, could it be that GitHub merges those 2 commits into one? That seems to be happening.

Ah yes, I had a similar issue regarding license key. Could be that we need to tweak something in the artifact build, or we can only use one key across environments? Not sure about this one CC @six7

@cuserox
Copy link
Contributor

cuserox commented Jul 30, 2024

2. The pushes still seems inconsistent as we noticed last week. If you make 2 commits to the same branch in a short amount of time, could it be that GitHub merges those 2 commits into one? That seems to be happening.

Let's pair on this.

@rbosker
Copy link
Collaborator Author

rbosker commented Jul 31, 2024

on point 2:

Screen.Recording.2024-07-30.at.19.33.31.mov

@six7 six7 linked a pull request Jul 31, 2024 that will close this issue
@cuserox cuserox closed this as completed by moving to ✅ Done in Tokens Studio for Figma Roadmap Jul 31, 2024
@cuserox cuserox added the plugin v2 variables, UI, WTCG format, Bitbucket label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0-rc10 bug Something isn't working plugin v2 variables, UI, WTCG format, Bitbucket
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants