Add tenacious strategy and use it as default #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The transport-reconnect could throw, but that wasn't handled correctly.
The simple client is thus significantly more robust to connection issues.
…ror_handling.permanent_client
…hub.com:toitware/mqtt into floitsch/better_error_handling.permanent_client
…ror_handling.permanent_client
kasperl
approved these changes
Nov 24, 2022
src/full_client.toit
Outdated
| @@ -248,7 248,8 @@ abstract class DefaultReconnectionStrategyBase implements ReconnectionStrategy: | |||
| ] | |||
|
|
|||
| receive_connect_timeout_ /Duration | |||
| attempt_delays_ /List | |||
| attempt_delays_ /List? | |||
| delay_lambda_/Lambda? | |||
There was a problem hiding this comment.
Suggested change
| delay_lambda_/Lambda? | |
| delay_lambda_ /Lambda? |
src/full_client.toit
Outdated
| if attempt_counter == 0: | ||
| // In the first iteration we try to connect without delay. | ||
| if not reuse_connection: | ||
| logger_.debug "Attempting to reconnect" |
There was a problem hiding this comment.
Is this already what you consider a reconnect (not just a connect)?
There was a problem hiding this comment.
Changed it to "(re)connect".
src/full_client.toit
Outdated
| hasn't received yet. | ||
| Theoretically, this is a protocol violation, but most brokers just drop the packet. | ||
|
|
||
| Note that this can also happen to clients that don't set the clien-session flag, but |
There was a problem hiding this comment.
Suggested change
| Note that this can also happen to clients that don't set the clien-session flag, but | |
| Note that this can also happen to clients that don't set the client-session flag, but |
src/full_client.toit
Outdated
|
|
||
| Note that this can also happen to clients that don't set the clien-session flag, but | ||
| where the broker lost the session. This can happen because the session expired, the | ||
| broker crashed, or a client with the same ID connectend in the meantime with a |
There was a problem hiding this comment.
Suggested change
| broker crashed, or a client with the same ID connectend in the meantime with a | |
| broker crashed, or a client with the same ID connected in the meantime with a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The simple client is thus significantly more robust to connection issues.