Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scala3/kernel core #1192

Merged
merged 51 commits into from
Jan 15, 2024
Merged

Scala3/kernel core #1192

merged 51 commits into from
Jan 15, 2024

Conversation

Grryum
Copy link
Contributor

@Grryum Grryum commented Nov 20, 2023 •
edited
Loading

Scala 3 is coming!

Here are modules already ported:

DoSOfRedRiver and others added 21 commits November 17, 2023 22:43
@DoSOfRedRiver @Grryum
Prepare Scala 3 cross-compilation
c0487b9
@dos65 @Grryum
Dispatch traits preparation.
be02b88
@Gryum @Grryum
WIP: prepared kernel to scala3.
0127f32
@dos65 @Grryum
Working on coreCE2.
658f0d9
@Grryum
Updated scalafmt
55ee0d1
@Grryum
Kernel macros finally done.
a42ab44
@Grryum
CE2 main code prepared for scala3.
324df9e
@Grryum
Adopted coreCE2 module and added macro with argument application.
0a8c130
@Grryum
Added implicit arguments apply.
442049f
@Grryum
WIP: most of macros prepared, working on problem with path dependent …
146313d 
…types.
@dos65 @Grryum
Solved path dependent type problem with asInstanceOf on macro site.
8f350ac
@Grryum
Finally coreCE2 migration done!!!
e8c863c
@Grryum
coreCE3 adopt.
186759f
@Grryum
Migrate ZIO2 interop to Scala 3.
6284e2e
@Grryum
Collect garbage.
d9c3600
@Grryum
Uncomment early failed test.
8d4a577
@Grryum
FIxed unused imports.
bbd942c
@Grryum
Fixed compat.unused.
fa7803a
@Grryum
Scala fmt tuning and applying..
1d7f2b2
@Grryum
Fixed kernel test.
5ac1787
@Grryum
Setup tpolecat plugin, fix warnings.
0f3d2bd
@Odomontois
Copy link
Member

Thank you very much for all of this colossal work.
The only thing that frightens me is the proposed implementation of Interop macros.
It clearly was done to be compatible with scala 2 definitions.
When I've implemented this I've missed some features of scala 3 inlines a lot, meaning I had to pass code line to the macro via structural type.
So I've had in mind that when that would be migrating to scala 3, we will rewrite the delegation implementation and "delegating" to instances would have scala-specificб but because of all that huge work, I hope we can do that in the folliwing PR.
So I have no options but to accept this PR, it feels like it's now or never

Odomontois
Odomontois approved these changes Nov 21, 2023
View reviewed changes
modules/kernel/src/main/scala-3/tofu/internal/Interop.scala Outdated

// For such cases old and classic `asInstanceOf` helps with extra casting.

val asInstanceOf = TypeRepr.of[AnyRef].typeSymbol.methodMember("asInstanceOf").head
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's very unpleasant. But I suppose we can cope with it for now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup! @road21 tried to fix it and replaced with widen.
Hope now it is not so unpleasant :)

@Grryum Grryum force-pushed the scala3/kernel core branch 2 times, most recently from 927a9a8 to 7e1b9f2 Compare November 22, 2023 22:55
@Grryum Grryum force-pushed the scala3/kernel core branch 2 times, most recently from 2abd492 to 9ea59d3 Compare November 23, 2023 08:37
@Grryum
Copy link
Contributor Author

Grryum commented Nov 23, 2023

partially closes #1068

@Odomontois
Copy link
Member

What happened with doc generation?

@Odomontois Odomontois merged commit 2ebd463 into tofu-tf:master Jan 15, 2024
10 checks passed
@Odomontois Odomontois mentioned this pull request Jan 24, 2024
Closed
@dos65 dos65 mentioned this pull request May 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Odomontois Odomontois Odomontois approved these changes

@danslapman danslapman Awaiting requested review from danslapman danslapman is a code owner

@catostrophe catostrophe Awaiting requested review from catostrophe catostrophe is a code owner

@FunFunFine FunFunFine Awaiting requested review from FunFunFine FunFunFine is a code owner

@oskin1 oskin1 Awaiting requested review from oskin1 oskin1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Grryum @Odomontois @DoSOfRedRiver @dos65 @Gryum @road21