Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): remove useless logic of use favorite #7533

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

forehalo
Copy link
Member

@forehalo forehalo commented Jul 18, 2024

closes #7534

Copy link

graphite-app bot commented Jul 18, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @forehalo and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Jul 18, 2024

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.67%. Comparing base (9160469) to head (133888d).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #7533       /-   ##
==========================================
  Coverage   57.62%   57.67%    0.04%     
==========================================
  Files         909      909              
  Lines       40289    40289              
  Branches     4555     4556        1     
==========================================
  Hits        23218    23237       19     
  Misses      16716    16698      -18     
  Partials      355      354       -1     
Flag Coverage Δ
server-test 78.42% <ø> ( 0.08%) ⬆️
unittest 29.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Jul 18, 2024

Merge activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

BlockSuiteError: val does not exist
2 participants