Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): select page modal's list is not visiable #7531

Merged

Conversation

CatsJuice
Copy link
Member

@CatsJuice CatsJuice commented Jul 18, 2024

fix AF-1076

CleanShot 2024-07-18 at 10.18.41.gif

Copy link

graphite-app bot commented Jul 18, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatsJuice and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Jul 18, 2024

@CatsJuice CatsJuice marked this pull request as ready for review July 18, 2024 02:19
@JimmFly
Copy link
Member

JimmFly commented Jul 18, 2024

Could you please add tests for this fix?

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 57.62%. Comparing base (ad97083) to head (b9d84fe).

Files Patch % Lines
...nts/page-list/view/edit-collection/select-page.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #7531       /-   ##
==========================================
- Coverage   57.63%   57.62%   -0.01%     
==========================================
  Files         909      909              
  Lines       40286    40289        3     
  Branches     4555     4555              
==========================================
  Hits        23218    23218              
- Misses      16713    16716        3     
  Partials      355      355              
Flag Coverage Δ
server-test 78.34% <ø> (ø)
unittest 29.02% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Jul 18, 2024

Merge activity

@Brooooooklyn Brooooooklyn force-pushed the catsjuice/fix/select-page-dialog-list-not-visiable branch from 66275c3 to b9d84fe Compare July 18, 2024 04:06
@graphite-app graphite-app bot merged commit b9d84fe into canary Jul 18, 2024
32 checks passed
@graphite-app graphite-app bot deleted the catsjuice/fix/select-page-dialog-list-not-visiable branch July 18, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

4 participants