Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(infra): memento use undefined #7491

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Jul 12, 2024

No description provided.

Copy link

graphite-app bot commented Jul 12, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@EYHN EYHN marked this pull request as ready for review July 12, 2024 10:28
Copy link
Member Author

EYHN commented Jul 12, 2024

@github-actions github-actions bot added mod:infra Environment related issues and discussions app:core labels Jul 12, 2024
Copy link

nx-cloud bot commented Jul 12, 2024

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 57.69%. Comparing base (2f784ae) to head (0f14097).

Files Patch % Lines
...frontend/core/src/modules/storage/impls/storage.ts 0.00% 3 Missing ⚠️
...ore/src/components/affine/reference-link/index.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #7491    /-   ##
=======================================
  Coverage   57.69%   57.69%           
=======================================
  Files         910      910           
  Lines       40090    40090           
  Branches     4534     4535     1     
=======================================
  Hits        23131    23131           
  Misses      16606    16606           
  Partials      353      353           
Flag Coverage Δ
server-test 78.46% <ø> (ø)
unittest 29.11% <16.66%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the test Related to test cases label Jul 15, 2024
Copy link

graphite-app bot commented Jul 15, 2024

Merge activity

@graphite-app graphite-app bot merged commit 0f14097 into canary Jul 15, 2024
32 checks passed
@graphite-app graphite-app bot deleted the eyhn/refactor/undefined branch July 15, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:infra Environment related issues and discussions test Related to test cases
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

3 participants