Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): share-button's label of shared page should be 'shared' #7486

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

CatsJuice
Copy link
Member

close #7427

Copy link

graphite-app bot commented Jul 12, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@CatsJuice CatsJuice marked this pull request as ready for review July 12, 2024 06:01
@graphite-app graphite-app bot requested a review from forehalo July 12, 2024 06:01
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatsJuice and the rest of your teammates on Graphite Graphite

@graphite-app graphite-app bot requested review from EYHN, JimmFly and pengx17 and removed request for forehalo and EYHN July 12, 2024 06:01
Copy link

nx-cloud bot commented Jul 12, 2024

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.81%. Comparing base (1504239) to head (7082f7e).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #7486       /-   ##
==========================================
- Coverage   57.81%   57.81%   -0.01%     
==========================================
  Files         908      908              
  Lines       40090    40090              
  Branches     4534     4534              
==========================================
- Hits        23178    23177       -1     
- Misses      16559    16560        1     
  Partials      353      353              
Flag Coverage Δ
server-test 78.56% <ø> (ø)
unittest 29.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Jul 15, 2024

Merge activity

@forehalo forehalo force-pushed the catsjuice/fix/shared-button-text branch from 1588d4b to 7082f7e Compare July 15, 2024 06:21
@graphite-app graphite-app bot merged commit 7082f7e into canary Jul 15, 2024
32 checks passed
@graphite-app graphite-app bot deleted the catsjuice/fix/shared-button-text branch July 15, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

update SHARE button layout when a document IS shared.
3 participants