-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): values in edit not saved when closing info modal #7465
Conversation
Your org has enabled the Graphite merge queue for merging into canaryAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e3c3d1a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
packages/frontend/core/src/components/affine/page-properties/info-modal/info-modal.tsx
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## canary #7465 /- ##
==========================================
Coverage 57.69% 57.74% 0.04%
==========================================
Files 907 907
Lines 40251 40258 7
Branches 4569 4570 1
==========================================
Hits 23224 23246 22
Misses 16675 16660 -15
Partials 352 352
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
packages/frontend/core/src/components/affine/page-properties/info-modal/info-modal.tsx
Outdated
Show resolved
Hide resolved
packages/frontend/core/src/components/affine/page-properties/info-modal/info-modal.tsx
Outdated
Show resolved
Hide resolved
5aaed52
to
19ce7d9
Compare
5f94652
to
58c38cf
Compare
58c38cf
to
270d387
Compare
Merge activity
|
Before the modification, when the modal is closed, if a value is being edited, the input's on blur event cannot be triggered to automatically save. https://github.com/toeverything/AFFiNE/assets/102217452/60235cec-0022-4c4d-b213-28f2331a0c5b
Before the modification, when the modal is closed, if a value is being edited, the input's on blur event cannot be triggered to automatically save.
2024-07-10.5.11.25.mov