Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pages.*: add standard translation #9672

Merged
merged 5 commits into from
Dec 29, 2022
Merged

pages.*: add standard translation #9672

merged 5 commits into from
Dec 29, 2022

Conversation

kbdharun
Copy link
Member

@kbdharun kbdharun commented Dec 26, 2022 •
edited

Signed-off-by: K.B.Dharun Krishna [email protected]

Automatically generated alias pages using the script at https://github.com/tldr-pages/tldr/blob/main/scripts/set-alias-page.py and added links to it using the script at https://github.com/tldr-pages/tldr/blob/main/scripts/set-more-info-link.py.

Closes #9601 (My previous PR)

@kbdharun
pages./: Automatically add alias pages
16c5a91 
Signed-off-by: K.B.Dharun Krishna <[email protected]>
@github-actions github-actions bot added the translation Translate pages from one language to another. label Dec 26, 2022
@kbdharun kbdharun added mass changes Changes that affect multiple pages. review needed Prioritized PRs marked for reviews from maintainers. labels Dec 26, 2022
@kbdharun kbdharun marked this pull request as ready for review December 26, 2022 05:07
@kbdharun kbdharun changed the title pages./: Automatically add alias pages pages./: add alias pages Dec 26, 2022
@kbdharun kbdharun changed the title pages./: add alias pages pages.*: add alias pages Dec 26, 2022
@kbdharun kbdharun mentioned this pull request Dec 26, 2022
Closed
5 tasks
@navarroaxel navarroaxel changed the title pages.*: add alias pages pages.*: add alias page translation Dec 26, 2022
@kbdharun
Copy link
Member Author

kbdharun commented Dec 26, 2022 •
edited

NOTE: Please hold off on the merge of this PR. I found some false positive deletions. I will fix it later today. Done, now it is GTG I guess

@navarroaxel navarroaxel changed the title pages.*: add alias page translation pages.*: add standard translation Dec 26, 2022
@blueskyson
Copy link
Member

blueskyson commented Dec 28, 2022 •
edited

@kbdharun How did the false positives happen? Is there a bug in set-alias-page.py?

@kbdharun
Copy link
Member Author

kbdharun commented Dec 28, 2022 •
edited

@kbdharun How did the false positives happen? Is there a bug in set-alias-page.py?

It didn't occur in set-alias-page.py but in the set more info script from what I remember. The issue was in some translation the links weren't enclosed in <> so the script added another line. And on some pages especially in Windows (e.g curl) we have a single line of description. And the lines were replaced by just the links in script. I manually went through the modified files and fixed this.

@kbdharun
Copy link
Member Author

kbdharun commented Dec 29, 2022 •
edited

Can I merge this or should we wait for more reviews?

Edit: Done

@EmilyGraceSeville7cf
Copy link
Contributor

You can. :)

@kbdharun kbdharun merged commit 5257568 into tldr-pages:main Dec 29, 2022
@kbdharun kbdharun removed the review needed Prioritized PRs marked for reviews from maintainers. label Jan 1, 2023
@kbdharun kbdharun added the script-runs PRs where the scripts were executed (i.e alias page translations, etc). label Oct 2, 2023
@kbdharun kbdharun mentioned this pull request Oct 29, 2023
Merged
@acuteenvy acuteenvy mentioned this pull request May 6, 2024
Open
@sebastiaanspeck sebastiaanspeck mentioned this pull request May 7, 2024
Merged
@acuteenvy acuteenvy mentioned this pull request May 7, 2024
Closed
acuteenvy added a commit to acuteenvy/tldr that referenced this pull request Aug 17, 2024
@acuteenvy
Revert "pages.*: add standard translation (tldr-pages#9672)"
2f60864 
This partially reverts commit 5257568.
See tldr-pages#12757.
sebastiaanspeck pushed a commit that referenced this pull request Aug 22, 2024
@acuteenvy
Revert "pages.*: add standard translation (#9672)" (#13458)
2e96d16 
This partially reverts commit 5257568.
See #12757.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navarroaxel navarroaxel navarroaxel approved these changes

@blueskyson blueskyson blueskyson approved these changes

@pixelcmtd pixelcmtd Awaiting requested review from pixelcmtd pixelcmtd is a code owner

Assignees
No one assigned
Labels
mass changes Changes that affect multiple pages. script-runs PRs where the scripts were executed (i.e alias page translations, etc). translation Translate pages from one language to another.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kbdharun @blueskyson @EmilyGraceSeville7cf @navarroaxel