-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dnstracer: add page #8707
dnstracer: add page #8707
Conversation
Related to #6863 |
Thanks @CleanMachine1, totally missed that one. Should obviously be in brackets. Co-authored-by: CleanMachine1 <78213164 [email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Faro1991, I left some comments here for you to review.
Co-authored-by: Reinhart Previano Koentjoro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks for your contribution. I have some suggestions for this page.
Tip: We use mnemonics whenever possible for single-character flags.
Co-authored-by: K.B.Dharun Krishna <[email protected]>
Co-authored-by: K.B.Dharun Krishna <[email protected]>
Accidentally put this for -s as well Co-authored-by: K.B.Dharun Krishna <[email protected]>
Co-authored-by: K.B.Dharun Krishna <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks for your contribution.
Also, Welcome to tldr btw.
Hey, @Faro1991 seems like you haven't signed the CLA. Can you sign the Contributor License Agreement (CLA) at https://cla-assistant.io/tldr-pages/tldr? |
Hey, I did on my first PR, the check just took unusually long this time. 😅 |
Thanks, Now that all checks are clear. This PR is good to merge.
@reinhart1010 can you merge this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
common
,linux
,osx
,windows
,sunos
,android
, etc.1.9, ref: https://www.kali.org/tools/dnstracer/