Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

airmon-ng: add page #4974

Merged
merged 1 commit into from
Nov 27, 2020
Merged

airmon-ng: add page #4974

merged 1 commit into from
Nov 27, 2020

Conversation

frcroth
Copy link
Contributor

@frcroth frcroth commented Nov 19, 2020

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@CLAassistant
Copy link

CLAassistant commented Nov 19, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/airmon-ng.md:6: TLDR005 Example descriptions should end in a colon with no trailing characters
pages/common/airmon-ng.md:10: TLDR005 Example descriptions should end in a colon with no trailing characters
pages/common/airmon-ng.md:14: TLDR005 Example descriptions should end in a colon with no trailing characters
pages/common/airmon-ng.md:18: TLDR005 Example descriptions should end in a colon with no trailing characters

Please fix the error(s) and push again.

sbrl
sbrl requested changes Nov 20, 2020
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new page! I've left some comments below for you to review.

pages/common/airmon-ng.md Outdated Show resolved Hide resolved
pages/common/airmon-ng.md Outdated Show resolved Hide resolved
pages/common/airmon-ng.md Outdated Show resolved Hide resolved
pages/common/airmon-ng.md Outdated Show resolved Hide resolved
pages/common/airmon-ng.md Outdated Show resolved Hide resolved
pages/common/airmon-ng.md Outdated Show resolved Hide resolved
navarroaxel
navarroaxel approved these changes Nov 21, 2020
View reviewed changes
Copy link
Member

@navarroaxel navarroaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @frcroth, please don't push force, it's harder to us to track the suggestions and changes.

einverne
einverne approved these changes Nov 21, 2020
View reviewed changes
Copy link
Member

@einverne einverne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@frcroth frcroth requested a review from sbrl November 21, 2020 08:51
@navarroaxel navarroaxel added the new command Issues requesting creation of a new page. label Nov 21, 2020
sbrl
sbrl approved these changes Nov 27, 2020
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @frcroth!

@sbrl sbrl merged commit c27417d into tldr-pages:master Nov 27, 2020
@frcroth frcroth deleted the airmon-ng branch November 27, 2020 07:30
@reinhart1010 reinhart1010 mentioned this pull request Jun 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navarroaxel navarroaxel navarroaxel approved these changes

@einverne einverne einverne approved these changes

@sbrl sbrl sbrl approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@frcroth @CLAassistant @tldr-bot @navarroaxel @einverne @sbrl