Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tshark: add page #2758

Merged
merged 13 commits into from
Feb 7, 2019
Merged

tshark: add page #2758

merged 13 commits into from
Feb 7, 2019

Conversation

NargiT
Copy link
Contributor

@NargiT NargiT commented Feb 6, 2019 •
edited

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform folder (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.

Special thanks to @jvns for here inspiring post https://twitter.com/b0rk/status/1091733136935923717

@CLAassistant
Copy link

CLAassistant commented Feb 6, 2019 •
edited

CLA assistant check
All committers have signed the CLA.

@tldr-bot
Copy link

tldr-bot commented Feb 6, 2019

The build for this PR has failed with the following error(s):

Error: Parse error on line 23:
...y fields to output `tshark -T fields -...
---------------------^
Expecting 'BACKTICK', got 'TEXT'
pages/linux/tshark.md:3: TLDR004 Command descriptions should end in a period
pages/linux/tshark.md:13: TLDR005 Example descriptions should end in a colon
pages/linux/tshark.md:21: TLDR005 Example descriptions should end in a colon

Please fix the error(s) and push again.

@NargiT
Copy link
Contributor Author

NargiT commented Feb 6, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

waiting an answer from @jvns before to accept the CLA

@owenvoke owenvoke added the new command Issues requesting creation of a new page. label Feb 6, 2019
@NargiT
Copy link
Contributor Author

NargiT commented Feb 6, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

waiting an answer from @jvns before to accept the CLA

Done -> https://twitter.com/b0rk/status/1093143505281658881

@mebeim mebeim changed the title tshark: add tshark tshark: add page Feb 6, 2019
mebeim
mebeim requested changes Feb 6, 2019
View reviewed changes
Copy link
Member

@mebeim mebeim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NargiT, thank you for your contribution! tshark is a super useful command. I've left some comments for you to review.

pages/linux/tshark.md Outdated Show resolved Hide resolved
pages/linux/tshark.md Outdated Show resolved Hide resolved
pages/linux/tshark.md Outdated Show resolved Hide resolved
pages/linux/tshark.md Outdated Show resolved Hide resolved
pages/linux/tshark.md Outdated Show resolved Hide resolved
pages/linux/tshark.md Outdated Show resolved Hide resolved
pages/linux/tshark.md Outdated Show resolved Hide resolved
pages/linux/tshark.md Outdated Show resolved Hide resolved
pages/linux/tshark.md Outdated Show resolved Hide resolved
pages/linux/tshark.md Outdated Show resolved Hide resolved
mebeim
mebeim requested changes Feb 6, 2019
View reviewed changes
pages/linux/tshark.md Outdated Show resolved Hide resolved
@NargiT
Copy link
Contributor Author

NargiT commented Feb 7, 2019

I think I merge/fixed all the changes let me know if it's ok

mebeim
mebeim approved these changes Feb 7, 2019
View reviewed changes
Copy link
Member

@mebeim mebeim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking fine to me 👍 Thanks again.

@owenvoke owenvoke merged commit 0428b03 into tldr-pages:master Feb 7, 2019
@kbdharun kbdharun mentioned this pull request Oct 16, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owenvoke owenvoke owenvoke approved these changes

@mebeim mebeim mebeim approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@NargiT @CLAassistant @tldr-bot @owenvoke @mebeim