Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arp-scan: add page #1699

Merged
merged 2 commits into from
Nov 30, 2017
Merged

arp-scan: add page #1699

merged 2 commits into from
Nov 30, 2017

Conversation

tbarusseau
Copy link


  • The page (if new), does not already exist in the repo.

  • The page (if new), has been added to the correct platform folder:
    common/ if it's common to all platforms, linux/ if it's Linux-specific, and so on.

  • The page has 8 or fewer examples.

  • The PR is appropriately titled:
    <command name>: add page for new pages, or <command name>: <description of changes> for pages being edited

  • The page follows the contributing guidelines

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the new page, @Neph0! I've just got a few points I'm unclear on, which I've commented about below :-)


`arp-scan --localnet`

- Scan an IP network with a custom bits mask:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be "bitmask"?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right, I'll fix this when I have some free time!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! Just @mention me in a comment once you've made the changes.


`arp-scan {{127.0.0.0}}-{{127.0.0.31}}`

- Scan an IN network with a custom net mask:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between an IP network and an IN network?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The difference is a typo, my mistake


> Send ARP packets to hosts on the local network to scan which ones answer.

- Scan the current local network:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IP / IN are mentioned below, but not specified here.....?

@agnivade agnivade added the new command Issues requesting creation of a new page. label Nov 29, 2017
Copy link
Member

@agnivade agnivade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice page !

@sbrl sbrl merged commit 179de05 into tldr-pages:master Nov 30, 2017
@sbrl
Copy link
Member

sbrl commented Nov 30, 2017

Thanks, @Neph0!

@tbarusseau
Copy link
Author

No problem, thanks to whoever started this great project 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants