Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pwn: add page #12352

Merged
merged 11 commits into from
Mar 1, 2024
Merged

pwn: add page #12352

merged 11 commits into from
Mar 1, 2024

Conversation

sufyandaredevil
Copy link
Contributor

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Feb 24, 2024
gutjuri
gutjuri reviewed Feb 24, 2024
View reviewed changes
Copy link
Member

@gutjuri gutjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. I have some comments.

pages/linux/pwn.md Outdated Show resolved Hide resolved
pages/linux/pwn.md Outdated Show resolved Hide resolved
pages/linux/pwn.md Outdated Show resolved Hide resolved
pages/linux/pwn.md Outdated Show resolved Hide resolved
pages/linux/pwn.md Outdated Show resolved Hide resolved
pages/linux/pwn.md Outdated Show resolved Hide resolved
pages/linux/pwn.md Outdated Show resolved Hide resolved
pages/linux/pwn.md Outdated Show resolved Hide resolved
pages/linux/pwn.md Outdated Show resolved Hide resolved
pages/linux/pwn.md Outdated Show resolved Hide resolved
sufyandaredevil
sufyandaredevil commented Feb 24, 2024
View reviewed changes
Copy link
Contributor Author

@sufyandaredevil sufyandaredevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions applied 👍

gutjuri
gutjuri approved these changes Feb 24, 2024
View reviewed changes
Copy link
Member

@gutjuri gutjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

sebastiaanspeck
sebastiaanspeck reviewed Feb 25, 2024
View reviewed changes
pages/linux/pwn.md Outdated Show resolved Hide resolved
sufyandaredevil
sufyandaredevil commented Feb 25, 2024
View reviewed changes
Copy link
Contributor Author

@sufyandaredevil sufyandaredevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

sufyandaredevil
sufyandaredevil commented Feb 25, 2024
View reviewed changes
Copy link
Contributor Author

@sufyandaredevil sufyandaredevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes applied

kbdharun
kbdharun approved these changes Feb 25, 2024
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, LGTM after the above suggestion.

@kbdharun
Copy link
Member

kbdharun commented Feb 27, 2024 •
edited

@sufyandaredevil Merging the branch with the main isn't required for most cases as we Squash & Merge PRs (you would only need to do it if the same file is modified somewhere else and you need to see if the changes would conflict).

kbdharun
kbdharun reviewed Feb 27, 2024
View reviewed changes
pages/linux/pwn.md Outdated Show resolved Hide resolved
fazlearefin
fazlearefin reviewed Feb 28, 2024
View reviewed changes
pages/linux/pwn.md Outdated Show resolved Hide resolved
sufyandaredevil
sufyandaredevil commented Feb 28, 2024
View reviewed changes
Copy link
Contributor Author

@sufyandaredevil sufyandaredevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes applied

@fazlearefin
Copy link
Member

Changes applied

Looks like the pwn cyclic command is still unresolved.

@fazlearefin fazlearefin mentioned this pull request Feb 28, 2024
Open
@sufyandaredevil @fazlearefin
Update pages/linux/pwn.md
adfaf41 
Co-authored-by: Fazle Arefin <[email protected]>
kbdharun
kbdharun approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

@kbdharun kbdharun merged commit b073192 into tldr-pages:main Mar 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fazlearefin fazlearefin fazlearefin approved these changes

@sebastiaanspeck sebastiaanspeck sebastiaanspeck left review comments

@gutjuri gutjuri gutjuri approved these changes

@kbdharun kbdharun kbdharun approved these changes

@cyqsimon cyqsimon Awaiting requested review from cyqsimon cyqsimon is a code owner

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sufyandaredevil @kbdharun @fazlearefin @sebastiaanspeck @gutjuri