Fix debug build with VS2015 #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The debug build on Windows for Native CLR was throwing linker errors because the wrong MSVCRT was being linked in. The fix is to use the runtime multi-threaded *debug* DLL, and the best solution to getting node-gyp to use it is to set the RuntimeLibrary property to '3'. Docs on RuntimeLibrary property: https://msdn.microsoft.com/en-us/library/aa652367(v=vs.71).aspx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The debug build on Windows for Native CLR was throwing linker errors
because the wrong MSVCRT was being linked in.
The fix is to use the runtime multi-threaded debug DLL, and the best
solution to getting node-gyp to use it is to set the RuntimeLibrary
property to '3'.
Docs on RuntimeLibrary property:
https://msdn.microsoft.com/en-us/library/aa652367(v=vs.71).aspx
Fix for #454