Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the first version of tinyms serving module #3

Merged
merged 2 commits into from
Feb 2, 2021
Merged

Add the first version of tinyms serving module #3

merged 2 commits into from
Feb 2, 2021

Conversation

leonwanghui
Copy link
Contributor

@leonwanghui leonwanghui commented Jan 27, 2021

Please NOTICE that this is the first verison of TinyMS Serving module implementation, and a lot of changes and design proposal would be added later.

What have we done?

These jobs below have be targeted by this PR:

  • Develop client and server module beside serving module, and expose start, shutdown and predict method to the public
  • Design a simple CS communication mechanism by using requests and flask package
  • Design the intial JSON payload when predicting an image from the serving client

Next step

For the whole serving framework, we still have a lot of work to be finished:

  • Move servable definition from client to server module, which means users don't have to specify the detailed information of servable when predicting an image
  • We need to design a product-ready CS communication mechanism, possibily relied on openapi-generator
  • Some unit tests and e2e tests would be added later

@leonwanghui leonwanghui changed the title [WIP] Add the first version of tinyms serving module Add the first version of tinyms serving module Feb 2, 2021
Copy link
Contributor

@lyd911 lyd911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@huxiaoman7
Copy link
Collaborator

lgtm

@leonwanghui leonwanghui merged commit 32dd238 into tinyms-ai:main Feb 2, 2021
@leonwanghui leonwanghui deleted the serving branch February 2, 2021 07:18
lyd911 added a commit that referenced this pull request Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants