Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

De-duplicate dependencies #4149

Open
brson opened this issue Jan 30, 2019 · 3 comments
Open

De-duplicate dependencies #4149

brson opened this issue Jan 30, 2019 · 3 comments
Labels
component/build-time Component: Compilation time help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. status/mentor This issue is currently mentored

Comments

@brson
Copy link
Contributor

brson commented Jan 30, 2019

There are a number of duplicate dependencies in our crate graph, adding to compile times. cargo tree might help to find them. Eliminate a many as possible.

Create a whitelist of allowed dupes, and a CI script that checks it; to avoid regressions, and ensure we know when we're adding dupes.
@brson brson added the component/build-time Component: Compilation time label Jan 30, 2019
@brson
Copy link
Contributor Author

brson commented Feb 10, 2019

This is a fairly straightforward task that a new contributor could take on. Though it's straightforward, it's non-trivial because it will in some cases involve working upstream to upgrade dependencies.

I can mentor.

@brson
Copy link
Contributor Author

brson commented Feb 10, 2019

Time the release build before and after. Measure the binary size before and after.

@brson brson added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. status/mentor This issue is currently mentored labels Feb 10, 2019
@brson
Copy link
Contributor Author

brson commented Feb 12, 2019

cargo-bloat can help roughly determine the size of the dupes with --crates with some simple math.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/build-time Component: Compilation time help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. status/mentor This issue is currently mentored
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brson