Support configuring election timeout range #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddontang
reviewed
May 20, 2018
src/raft.rs
Outdated
| /// to become leader. This configuration ensures that the randomized election_timeout | ||
| /// will always be suit in [min_election_tick, max_election_tick). | ||
| /// If it is None, then election_tick will be chosen. | ||
| pub min_election_tick: Option<usize>, |
There was a problem hiding this comment.
I think you can remove Option here, you can set min to election timeout and max to 2 x election timeout explicitly if they are 0 at initialization.
|
LGTM But CI failed. |
|
PTAL |
|
LGTM. |
hicqu
approved these changes
May 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, a node is expected to take less chance to become a leader due to reasons like poor performance. We can make it happen by customizing the randomized election timeout.