Upgrade protobuf to 1.6. #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think it's a good idea. This will require |
hicqu
changed the title
|
LGTM |
|
I think we should add a comment about how to generate the proto. |
|
PTAL @BusyJay |
BusyJay
previously approved these changes
May 14, 2018
Hoverbear
previously approved these changes
May 14, 2018
|
@hicqu This looks ok but I'd also like to see some instruction how to regenerate the proto if needed. |
|
any update? |
|
PTAL @Hoverbear . |
siddontang
reviewed
May 17, 2018
| If proto file `eraftpb.proto` changed, run the command to regenerate `eraftpb.rs`: | ||
|
|
||
| ```bash | ||
| protoc proto/eraftpb.proto --rust_out=src |
There was a problem hiding this comment.
no need to set the output path?
There was a problem hiding this comment.
It's seted with --rust_out.
Hoverbear
approved these changes
May 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade protobuf to 1.6.