Initial ROS2 Jazzy support #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xavier BROQUERE <[email protected]>
|
Thank you! |
|
Updated the version and published it to crates.io. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I tried to integrate ROS2 Jazzy support in the same way than Iron.
Here the log of compilation:
`make -C tests/common
make[1]: Entering directory '/home/az01958/src/safe_drive/tests/common'
ros2msg_to_rs -i ../../supplements/ros2/src -o msgs
generating: msgs/example_msg/msg/buz.rs
generating: msgs/example_msg/srv/add_three_ints.rs
generating: msgs/example_msg/msg/foo.rs
generating: msgs/example_msg/msg/std_msg.rs
generating: msgs/example_msg/msg/num.rs
generating: msgs/example_msg/msg.rs
generating: msgs/example_msg/srv.rs
generating: msgs/mod.rs
generating: msgs/example_msg/mod.rs
make[1]: Leaving directory '/home/az01958/src/safe_drive/tests/common'
cd supplements/ros2 && colcon build
Starting >>> example_msg
Finished <<< example_msg [1.74s]
Summary: 1 package finished [1.94s]
cargo build
warning:
externfn uses typeu128, which is not FFI-safe--> src/rcl/jazzy.rs:15087:9
|
15087 | / unsafe extern "C" fn(
15088 | | serialization_support: *mut rosidl_dynamic_typesupport_serialization_support_impl_t,
15089 | | dynamic_data: *mut rosidl_dynamic_typesupport_dynamic_data_impl_t,
15090 | | id: rosidl_dynamic_typesupport_member_id_t,
15091 | | value: u128,
15092 | | ) -> rcutils_ret_t,
| |__________________________^ not FFI-safe
|
= note: 128-bit integers don't currently have a known stable ABI
= note:
#[warn(improper_ctypes_definitions)]on by defaultwarning:
externfn uses typeu128, which is not FFI-safe--> src/rcl/jazzy.rs:15285:9
|
15285 | / unsafe extern "C" fn(
15286 | | serialization_support: *mut rosidl_dynamic_typesupport_serialization_support_impl_t,
15287 | | dynamic_data: *mut rosidl_dynamic_typesupport_dynamic_data_impl_t,
15288 | | value: u128,
15289 | | out_id: *mut rosidl_dynamic_typesupport_member_id_t,
15290 | | ) -> rcutils_ret_t,
| |__________________________^ not FFI-safe
|
= note: 128-bit integers don't currently have a known stable ABI
warning:
safe_drive(lib) generated 2 warningsFinished dev [unoptimized debuginfo] target(s) in 0.09s
`
Result of test:
test result: ok. 50 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 16.10sCan you please review and help to enable Jazzy support ?
Thanks!