Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate test names #6901

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Fix duplicate test names #6901

merged 1 commit into from
Aug 23, 2023

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Aug 4, 2023

Cases like this can cause mild confusion. Should testthat warn here?

@DavisVaughan
Copy link
Member

It can also sometimes mess up snapshot tests, so that's not a bad idea. Maybe we'd make the warning optional though?

@DavisVaughan DavisVaughan merged commit 001de12 into main Aug 23, 2023
11 checks passed
@DavisVaughan DavisVaughan deleted the b-dupe-test-names branch August 23, 2023 13:43
@krlmlr krlmlr mentioned this pull request Aug 23, 2023
Open
@krlmlr
Copy link
Member Author

krlmlr commented Aug 23, 2023

Thanks, filed issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krlmlr @DavisVaughan