Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JSON and XML output formatting for check-updates command #104

Merged
merged 2 commits into from
Nov 2, 2021
Merged

Fix JSON and XML output formatting for check-updates command #104

merged 2 commits into from
Nov 2, 2021

Conversation

bacali95
Copy link
Collaborator

closes #78

The object structures is just a suggestion and it is up for discussion:

e.forObject()
        .set("package", update.getAvailable().getId().getShortName())
        .set("local-version", update.getLocal().getId().getVersion().toString())
        .set("new-version", update.getAvailable().getId().getVersion().toString())
        .build();

@bacali95 bacali95 self-assigned this Oct 30, 2021
@thevpc
Copy link
Owner

thevpc commented Oct 30, 2021

Good Suggestion. However I do prefer id names (without dashes) to help serialization in tools calling nuts. Hence use localVersion instead of local-version

@bacali95 bacali95 force-pushed the fix/add-json-and-xml-output-for-check-updates-command branch from 7826098 to ad528b3 Compare October 30, 2021 21:20
@bacali95 bacali95 requested a review from thevpc October 30, 2021 21:21
@thevpc thevpc merged commit 6d75771 into master Nov 2, 2021
@thevpc thevpc deleted the fix/add-json-and-xml-output-for-check-updates-command branch November 2, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thevpc thevpc Awaiting requested review from thevpc

Assignees

@bacali95 bacali95

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"nuts check-updates --all --json" returns an empty string
2 participants
@bacali95 @thevpc