Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide some annoyances #29

Merged
merged 4 commits into from
Apr 27, 2018
Merged

Hide some annoyances #29

merged 4 commits into from
Apr 27, 2018

Conversation

jorgegonzalez
Copy link
Contributor

@jorgegonzalez jorgegonzalez commented Apr 17, 2018

Closes #24. This hides the "Pardon the Interruption" (image 1) message and the "Do not track" banners (image 2).

image

image

This hides the "Pardon the Interruption" message and the "Do not track" banners.
@jorgegonzalez jorgegonzalez changed the title Hide some annoyances [WIP] Hide some annoyances Apr 17, 2018
@jorgegonzalez jorgegonzalez changed the title [WIP] Hide some annoyances Hide some annoyances Apr 17, 2018
medium.css Outdated
display: none;
}

.u-overflowHidden {
overflow: scroll !important;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious -- what does this address? I'm seeing scrollbars in more places with it:
screenshot from 2018-04-18 18-49-00

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "pardon the interruption" overlay prevents scrolling, even after it is hidden. I'll work on a better fix for this soon, I've been quite busy lately.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, makes sense! I'm working on a fix now

This blocks the annoying "Pardon the interruption" dialog without
preventing other parts of the UI from working correctly (basically.
see comments).
@thebaer
Copy link
Owner

thebaer commented Apr 26, 2018

@jorgegonzalez I think I got it all fixed. Whenever you have a free moment, would you mind pulling down the changes and making sure they work for you, too?

By the way, I was able to test this without going into incognito by clearing localStorage first.

@jorgegonzalez
Copy link
Contributor Author

Forgive me for my delay. I just tested the changes and everything seems to be working brilliantly. I appreciate your effort in finishing this PR.

@thebaer
Copy link
Owner

thebaer commented Apr 27, 2018

Great. Thank you for getting it started! Merging now.

@thebaer thebaer merged commit 654839d into thebaer:master Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants