Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide sign up/sign in "Pardon the interruption" popup #24

Closed
jorgegonzalez opened this issue Apr 6, 2018 · 7 comments
Closed

Hide sign up/sign in "Pardon the interruption" popup #24

jorgegonzalez opened this issue Apr 6, 2018 · 7 comments
Milestone

Comments

@jorgegonzalez
Copy link
Contributor

image

Not sure if this has been reported already.

@jorgegonzalez jorgegonzalez changed the title Hide sign up/in popup Hide sign up/sign in "Pardon the interruption" popup Apr 6, 2018
@panckreous
Copy link
Contributor

Ha, this is one project where duplicate issues are more likely valid new issues than not. Matt cures one malady but in no time a newer, stronger, grosser variation breaks out.

@jorgegonzalez
Copy link
Contributor Author

jorgegonzalez commented Apr 6, 2018

I'll try and send a PR this weekend to fix this.

@thebaer
Copy link
Owner

thebaer commented Apr 6, 2018

Thanks @jorgegonzalez, that would be awesome!

@jorgegonzalez
Copy link
Contributor Author

I've been trying to fix this but I can't reliably trigger the overlay 🤔

@thebaer
Copy link
Owner

thebaer commented Apr 17, 2018

@jorgegonzalez I was just able to get it to happen twice by opening an incognito window, going to Medium.com and clicking on four different articles... Maybe that'll work?

@jorgegonzalez
Copy link
Contributor Author

@thebaer Just opened a PR.

@thebaer
Copy link
Owner

thebaer commented Apr 18, 2018

@jorgegonzalez looks great! Left a comment about some potential side effects -- will merge as soon as they're addressed.

@thebaer thebaer added this to the v1.5 milestone Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants