Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra linebreak at end #60

Merged
merged 1 commit into from
Jan 9, 2019
Merged

Remove extra linebreak at end #60

merged 1 commit into from
Jan 9, 2019

Conversation

rhendric
Copy link
Contributor

@rhendric rhendric commented Jan 7, 2019

Hey, aha is pretty cool! I'm using it in conjuction with wkhtmltoimage to capture clean ‘screenshots’ of terminal output.

One issue I've noticed is that the images thus produced often have an extra blank line at the end, which I think is due to this \n inserted with the span close tag when there's some ANSI formatting still in effect at the last character—this PR takes it out.

@theZiz
Copy link
Owner

theZiz commented Jan 9, 2019

You are probably right, thanks for the fix! 👍

@theZiz theZiz merged commit f9faec5 into theZiz:master Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants