Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update helm installation instruction #7132

Merged

Conversation

bavarianbidi
Copy link
Contributor

@bavarianbidi bavarianbidi commented Feb 12, 2024

the prometheus helm chart is a community maintained chart since a few years. With that, the old example pointed to an old chart and the provided example values aren't also working anymore.

This update the documentation.

Fixes #6301

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Verification

helm repo add prometheus-community https://prometheus-community.github.io/helm-charts
helm template --version="25.11.0" --namespace="prometheus" --values dev-thanos.yaml prometheus prometheus-community/prometheus

the prometheus helm chart is a community maintained chart since a few
years. With that, the old example pointed to an old chart and the
provided example values aren't also working anymore.

This update the documentation.

Signed-off-by: Mario Constanti <[email protected]>
@bavarianbidi bavarianbidi force-pushed the update_helm_installation_instruction branch from e44fe6f to 0bf17ae Compare February 12, 2024 05:39
fpetkovski
fpetkovski previously approved these changes Feb 12, 2024
Copy link
Contributor

@fpetkovski fpetkovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@fpetkovski
Copy link
Contributor

You should be able to fix the CI by running make docs.

@fpetkovski fpetkovski merged commit f5ca5a8 into thanos-io:main Feb 12, 2024
20 checks passed
@bavarianbidi bavarianbidi deleted the update_helm_installation_instruction branch February 12, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kubernetes-helm: Bring sample up to date with latest prometheus helm chart
2 participants