Hello, thanks for the PR. I'm curious what compiler libc version complained about cfmakeraw? I'm guessing a version of libc that didn't recognize _DEFAULT_SOURCE? Does it work if you define _BSD_SOURCE?

Trying to work out if we actually need to fuss over this. We already need _XOPEN_SOURCE for wcwidth which I see no way around unless we bundle something like wcwidth9. There are people using this library on retro / exotic systems that seem to be OK (last I checked).

thanks for the response! i'm using the musl libc and mainly use gcc 13.2.0, but i've also replicated this warning with clang 17.0.6.

defining _BSD_SOURCE fixes the warning for me.

termios.h on my system contains this:

#if defined(_GNU_SOURCE) || defined(_BSD_SOURCE)
void cfmakeraw(struct termios *);
int cfsetspeed(struct termios *, speed_t);
#endif

so defining _BSD_SOURCE in termbox2.h can be an alternative fix for musl.

Hm, I wonder why this isn't working for you. That was added a decade ago in musl.

i think i've figured it out; most musl headers include features.h, which means that including (almost any) header before termbox2.h causes features.h to be included without _DEFAULT_SOURCE, and as such it doesn't define _BSD_SOURCE. later on, after the definition of _DEFAULT_SOURCE, features.h won't be re-included since it already has been included once, meaning that _BSD_SOURCE won't get defined.

this means that including termbox2.h before any other headers also fixes the warning; i've tested it and it does indeed silence the warning. passing -D_DEFAULT_SOURCE to the compiler also fixes the warning.

Thank you @iusevoidbtw. I opened #78 based on your findings. Please have a look.