Fix handling of empty records in write_parquet
#4874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
added
bug
dominiklohmann
force-pushed
the
topic/parquet-empty-records
branch
2 times, most recently
from
6892518 to
6a83d1c
Compare
Parquet does fundamentally not support empty records. The commonly used workaround to this is to replace empty struct types with null types.
dominiklohmann
force-pushed
the
topic/parquet-empty-records
branch
from
6a83d1c to
5a630fa
Compare
dominiklohmann
commented
Dec 20, 2024
IyeOnline
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parquet does fundamentally not support empty records. The commonly used workaround to this is to replace empty struct types with null types.
This was initially reported in Discord from a user that ran into this problem.