Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

face-landmarks-detection dependency conflict #7905

Open
aptxyz opened this issue Aug 13, 2023 · 14 comments
Open

face-landmarks-detection dependency conflict #7905

aptxyz opened this issue Aug 13, 2023 · 14 comments
Assignees
@mattsoulanille @gaikwadrahul8
Labels
comp:models type:build/install

Comments

@aptxyz
Copy link

aptxyz commented Aug 13, 2023

Please make sure that this is a build/installation issue. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:build_template

System information

  • Win 11 Pro 22H2 22621.2134
  • node v20.3.0
  • npm 9.6.7

Describe the problem

npm install @tensorflow-models/face-landmarks-detection

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: undefined@undefined
npm ERR! Found: @tensorflow/[email protected]
npm ERR! node_modules/@tensorflow/tfjs-backend-webgl
npm ERR! peer @tensorflow/tfjs-backend-webgl@"^4.4.0" from @tensorflow-models/[email protected]
npm ERR! node_modules/@tensorflow-models/face-detection
npm ERR! @tensorflow-models/face-detection@"^1.0.1" from the root project
npm ERR! peer @tensorflow-models/face-detection@"~1.0.0" from @tensorflow-models/[email protected]
npm ERR! node_modules/@tensorflow-models/face-landmarks-detection
npm ERR! @tensorflow-models/face-landmarks-detection@"" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer @tensorflow/tfjs-backend-webgl@"^3.12.0" from @tensorflow-models/[email protected]
npm ERR! node_modules/@tensorflow-models/face-landmarks-detection
npm ERR! @tensorflow-models/face-landmarks-detection@"" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR!
npm ERR! For a full report see:
npm ERR! C:\Users\User\AppData\Local\npm-cache_logs\2023-08-13T02_50_36_950Z-eresolve-report.txt

image

dependency conflict, the face landmarks detection model use tfjs v3, however the model '[email protected]' update tfjs from v3 to v4
@gaikwadrahul8 gaikwadrahul8 self-assigned this Aug 13, 2023
@gaikwadrahul8
Copy link
Contributor

gaikwadrahul8 commented Aug 14, 2023 •
edited
Loading

Hi, @aptxyz

Apologize for the delayed response and thank you for bringing this issue to our attention, I checked @tensorflow-models/face-landmarks-detection and it's using this version "^3.12.0" and for this package @tensorflow-models/[email protected] it's using "^4.4.0"

Could you please try to use this package version @tensorflow-models/[email protected] where it's using this version "^3.14.0" and let us know whether is it working as expected or not ?

We'll dig more into this issue with dependancies conflict and if possible we'll try to update package dependancies for @tensorflow-models/face-landmarks-detection to V4 because it's using the V3 package versions at the moment. Thank you!

@aptxyz
Copy link
Author

aptxyz commented Aug 19, 2023

I think I did tried install all three together [email protected] along with tfjs@3 & [email protected] without warning, and it's working as expected. But I eventually just download models from tfhub and use tfjs@4 as backend for various reasons.

@aptxyz aptxyz closed this as not planned Won't fix, can't repro, duplicate, stale Aug 19, 2023
@google-ml-butler
Copy link

Are you satisfied with the resolution of your issue?
Yes
No

@aptxyz aptxyz reopened this Aug 19, 2023
@JacobRMiller
Copy link

I'm running into the same issue. I also tried [email protected] along with tfjs@3 and [email protected] without success.

@github-actions
Copy link

This issue has been marked stale because it has no recent activity since 7 days. It will be closed if no further activity occurs. Thank you.

@github-actions github-actions bot added the stale label Aug 28, 2023
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

This issue was closed due to lack of activity after being marked stale for past 7 days.

@github-actions github-actions bot closed this as completed Sep 5, 2023
@google-ml-butler
Copy link

Are you satisfied with the resolution of your issue?
Yes
No

@iamsolankiamit
Copy link

Hey was anyone able to resolve this issue?

@Johnrobmiller
Copy link

This was never resolved. A maintainer ought to fix this!

@maazcloudhire
Copy link

Can someone please fix this?

@maazcloudhire
Copy link

I did --legacy-peer-deps. but now It's creating an issue in production.

@klimeryk
Copy link

Can confirm the issue still exists. Can't even run the demos from the official repository.

klimeryk added a commit to klimeryk/dealwithit that referenced this issue Sep 29, 2024
@klimeryk
Added face detection using tensorflow.js
2a48b2a 
Fixes #21, yay!
It's not perfect, and ideally I'd use https://github.com/tensorflow/tfjs-models/tree/master/face-landmarks-detection
But that model is lagging behind the `face-detection` one, so I could
not get it installed. See tensorflow/tfjs#7905
@mattsoulanille
Copy link
Member

This should now be fixed as of face-landmarks-detection 1.0.6, and it should no longer request version 3 and 4 of TFJS at the same time. I'll reopen this for now until I get confirmation that the fix works for your project.

klimeryk added a commit to klimeryk/dealwithit that referenced this issue Oct 12, 2024
@klimeryk
Try face-landmarks-detection
8470def 
It works after tensorflow/tfjs#7905 got fixed
:tada:
But, it's still not possible to use it in production due to tensorflow/tfjs#8290
@klimeryk
Copy link

klimeryk commented Oct 12, 2024 •
edited
Loading

@mattsoulanille, thank you so much for the follow-up! I've tested on a branch for my project and can confirm that the dependency conflict has been resolved 🎉 So this issue can be closed 🙇
However, for my use case, the library still cannot be used in production due to #8290. Looks like this model (maybe others?) are not compatible with https://vitejs.dev/ It would be hugely helpful if you could have a look if there's anything that can be done to fix that situation 🙏 I'll leave some notes there on my findings so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattsoulanille mattsoulanille

@gaikwadrahul8 gaikwadrahul8

Labels
comp:models type:build/install
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@pyu10055 @mattsoulanille @JacobRMiller @klimeryk @iamsolankiamit @aptxyz @Johnrobmiller @gaikwadrahul8 @maazcloudhire