Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint TensorFlow: Training checkpoints #1770

Merged
merged 4 commits into from
Dec 18, 2020
Merged

Lint TensorFlow: Training checkpoints #1770

merged 4 commits into from
Dec 18, 2020

Conversation

8bitmp3
Copy link
Contributor

@8bitmp3 8bitmp3 commented Dec 17, 2020

Splitting PR #1736 into smaller digestible bits. Thank you @lamberta @MarkDaoust

@google-cla google-cla bot added the cla: yes CLA has been signed label Dec 17, 2020
@8bitmp3 8bitmp3 mentioned this pull request Dec 17, 2020
Closed
@8bitmp3
Copy link
Contributor Author

8bitmp3 commented Dec 17, 2020

@lamberta This PR should be ready too. File: checkpoint.ipynb. Reviewed in #1769 by @lamberta and @anirudh161 Much obliged. Applying nbfmt still doesn't 🔜 ✅ CI test. I'm using the latest version (tensorflow-docs-0.0.022e5c5c6e3a3a932e4e73d1d3bf1bff9505769f1-) 🤔

lamberta
lamberta approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@lamberta lamberta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you
I rebased with the master branch and everything works now. May need to rebase some of the other PRs, as well.

@github-actions github-actions bot added the lgtm Community-added approval label Dec 17, 2020
@lamberta lamberta added the ready to pull Start merge process label Dec 17, 2020
@TensorFlow-Docs-Copybara TensorFlow-Docs-Copybara merged commit 4961914 into tensorflow:master Dec 18, 2020
@8bitmp3 8bitmp3 deleted the lint-checkpoint-guide branch December 18, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lamberta lamberta lamberta approved these changes

@anirudh161 anirudh161 Awaiting requested review from anirudh161

@MarkDaoust MarkDaoust Awaiting requested review from MarkDaoust

@yashk2810 yashk2810 Awaiting requested review from yashk2810

Assignees
No one assigned
Labels
cla: yes CLA has been signed lgtm Community-added approval ready to pull Start merge process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@8bitmp3 @lamberta @TensorFlow-Docs-Copybara