UserMenu refactoring #2374
Merged
UserMenu refactoring #2374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rossedfort
approved these changes
Oct 9, 2024
|
Like don't include the actionTooltip prop? When I wrap the Button in the Tooltip and pass it into the slot, it doesn't render. Thus the prop. |
|
Hah it's OK, I'm just salty on tooltips. But just FYI the tooltip probably won't show on mobile cause no hover, so I'm curious how you go that screenshot |
|
Yeah I think I'll remove the mobile tooltip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Pass UserMenu as a slot into the TopNav and BottomNav.
Also make all MenuItems hoverable, add a actionTooltip prop to Combobox, improve styles of bottom nav Namespace switcher.
Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?