Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo CI - First iteration #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

n0n0x
Copy link
Contributor

@n0n0x n0n0x commented Dec 18, 2017

Let's cross fingers and see if this works out as easy as I expected :P

@n0n0x n0n0x force-pushed the redo-ci branch 3 times, most recently from 2b6d0d9 to 25b9dc6 Compare December 18, 2017 23:55
@n0n0x n0n0x changed the title Redo CI Redo CI - First iteration Dec 19, 2017
@n0n0x
Copy link
Contributor Author

n0n0x commented Dec 19, 2017

Ok, this works. The thing is this should not be the definitive solution. So maybe do not merge this but use as a guide?

Some things to take into account:

  • Makefile: If I change this line to REPO_PATH := github.com/teamhephy/${SHORT_NAME} things stop working as shown in this build

  • Makefile: There should be a DEV_ENV_IMAGE on teamhephy's quay.io repo as per Makefile, say: DEV_ENV_IMAGE := quay.io/teamhephy/go-dev?

  • Go Files: Maybe there should be a search and replace on all imports for all *.go files

@kingdonb
Copy link
Member

Terrific, thank you for looking at this.

@Cryptophobia
Copy link
Member

@n0n0x : Thank you for looking at this and giving us the proposed changes here.

Do you use deis workflow in production?

Would you be interested in joining the maintainers of the hephy fork?

@n0n0x
Copy link
Contributor Author

n0n0x commented Jan 30, 2018

@Cryptophobia yes, we are heavily using deis in production right now running about 40 services.

We are from @streema we are a team of three, we code almost everything in python and we are interested in helping :), our GH usernames are: @matagus, @acangiani and of course me @n0n0x.

Cheers!

@Cryptophobia
Copy link
Member

Cryptophobia commented Jan 30, 2018

We are from @streema we are a team of three, we code almost everything in python and we are interested in helping :), our GH usernames are: @matagus, @acangiani and of course me @n0n0x.

Great! We would love to have more devs who use deis and are willing to contribute! Some of the components are built in python django - for example the controller.

I sent you a Slack invite on the Deis slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants