Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing coverage: Resizable / Growable (Shared)ArrayBuffers: Missing tests for some Array.prototype functions #3349

Open
marjakh opened this issue Dec 14, 2021 · 0 comments

Comments

@marjakh
Copy link
Contributor

marjakh commented Dec 14, 2021

There are tests like built-ins/Array/prototype/every/callbackfn-resize-arraybuffer , which invoke an Array.prototype.function with a TypedArray with resizable backing. But looks like we don't have tests for all funcs in Array.prototype. E.g., Array.prototype.join etc.

E.g., V8 currently has a "bug" or rather a missing implementation, that we don't use the correct length when you do Array.prototype.something.call(taWithResizableBacking). But there's no test262 testing failing because of this, as far as I can see.

We'd probably need tests which make the call 1) before resizing 2) after resizing, to make sure we always use the correct length.

cc @jugglinmike @syg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant