Registry functions: add :date and :time #51
Conversation
spec.emu
Outdated
| 1. Let _inputOptions_ be ? Get(_input_, *"options"*). | ||
| 1. Perform ? Call(Object.assign, *undefined*, « _opts_, _inputOptions_ »). |
There was a problem hiding this comment.
Option resolution should happen after value resolution, as it could fail and it has external visibility.
spec.emu
Outdated
| 1. Let _valueOf_ be ? Get(_input_, *"valueOf"*). | ||
| 1. If InstanceOfOperator(_input_, �te%) is *false* and IsCallable(_valueOf_) is *true*, set _input_ to Call(_valueOf_, _input_). | ||
| 1. If Type(_input_) is Number or String, let _value_ be ? Construct(�te%, « _input_ »). | ||
| 1. Else if Type(_input_) is Object, let _value_ be _input_. |
There was a problem hiding this comment.
If the previous steps were to work on value and not input, this line would be unnecessary.
|
@eemeli PTAL now. Regarding the first set of changes, I didn't entirely understand your comments (I think? I could be positively surprised) but I made some improvements that might address your concern. In the second set of changes, your comment made me realize that I was misreading the code? Sorry for that, the updated spec should make a lot more sense. |
Co-authored-by: Eemeli Aro <[email protected]>
|
Overall looks good to me, although I still feel like we could avoid repeating the |
ryzokuken
changed the title
|
@eemeli this might look better now :D |
Fix an error with
:dateTimeRefactor parts of
:dateTimeAdd
:date