Fix pattern-matching example to use "1" on left-hand side #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n right-hand side
eemeli
approved these changes
Apr 28, 2023
|
This change makes sense, but not for the reason you propose. The numerical value Now, the reason why this change still makes sense is that the content of the message is specific to the exact value, rather than the category. In English, those are the same, but in many other locales, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I"m following this example correctly, the left-hand side of the rule here needs to be
1, notone, since the JS code passes an object whosecountproperty is "1". If I"m understanding MF2 pattern-matching semantics correctly, the comparison between a selector (or rather, the result of evaluating the selector) and annmtokenkey is just a string comparison. So the MF2 code here would evaluate to"You have 1 new notifications", not"You have one new notification", which in turn doesn"t match the comment in the JS code.