Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move @internal markers to individual members #592

Merged
merged 4 commits into from
Mar 28, 2024

Conversation

rbuckton
Copy link
Contributor

@rbuckton rbuckton commented Mar 28, 2024

This builds on #591 by moving /*@internal*/ markers from classes to individual class elements so that class types are preserved broadly while still allowing us to remove individual /*@internal*/ markers on a case-by-case basis.

Fixes #416

Copy link
Contributor

@bakkot bakkot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thank you!

@bakkot bakkot merged commit fd938c8 into tc39:main Mar 28, 2024
2 checks passed
bakkot pushed a commit that referenced this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Published .d.ts files don't type-check
2 participants