Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor Updates #74

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Minor Updates #74

merged 1 commit into from
Oct 24, 2023

Conversation

madflojo
Copy link
Member

@madflojo madflojo commented Oct 24, 2023 •
edited by coderabbitai bot
Loading

Simple documentation update for something that should have been there but was missing.

Summary by CodeRabbit

  • New Feature: Introduced the ability to enable and select a SQL store through environment variables. This allows users to choose between postgres and mysql as their preferred SQL store.
  • Documentation: Updated the configuration documentation to reflect these changes. The enable_sqlstore option has been renamed to enable_sql, and sqlstore_type is now used to specify the supported platform.

These changes provide users with more flexibility and clarity when configuring their SQL data storage options.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 24, 2023 •
edited
Loading

Walkthrough

The changes introduce two new environment variables for enabling and selecting a SQL store in Tarmac. The modifications are primarily in the configuration and documentation, with no significant alterations or additions.

Changes

File Path Summary
docs/running-tarmac/configuration.md Introduced APP_ENABLE_SQL and APP_SQL_TYPE environment variables for enabling and selecting a SQL store.
docs/running-tarmac/sql.md Renamed enable_sqlstore to enable_sql and introduced sqlstore_type for specifying the SQL platform.

🐇

"In the land of code, changes are afoot,

SQL store options, aren't they a hoot?

With a hop, skip, and a jump, we make our way,

Celebrating the progress of the day. 🎉"

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.json

coderabbitai[bot]
coderabbitai bot reviewed Oct 24, 2023
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 158acbd and 81574b1.
Files selected for processing (2)
  • docs/running-tarmac/configuration.md (1 hunks)
  • docs/running-tarmac/sql.md (1 hunks)
Files skipped from review due to trivial changes (2)
  • docs/running-tarmac/configuration.md
  • docs/running-tarmac/sql.md

@codecov
Copy link

codecov bot commented Oct 24, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (158acbd) 82.75% compared to head (81574b1) 82.75%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #74    /-   ##
=======================================
  Coverage   82.75%   82.75%           
=======================================
  Files          12       12           
  Lines        1148     1148           
=======================================
  Hits          950      950           
  Misses        152      152           
  Partials       46       46

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@madflojo madflojo merged commit 6e58cd9 into main Oct 24, 2023
11 checks passed
@madflojo madflojo deleted the minor-updates branch October 24, 2023 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@madflojo