Updating go mod with new location #62

madflojo · 2023-10-01T00:28:42Z

Summary by CodeRabbit

Chore: Updated the build process across multiple Makefiles to use the latest version of TinyGo Docker image instead of a specific version (0.25.0). This ensures that the most recent features and fixes from TinyGo are incorporated during the build process.
Refactor: Adjusted import statements in various Go files for better organization and consistency. These changes do not affect the functionality of the code but improve its readability and maintainability.
Chore: Modified Docker run commands in Makefiles to include the --rm flag, ensuring proper cleanup of containers after each build. This change enhances resource management during the build process.

coderabbitai · 2023-10-01T00:39:58Z

Walkthrough

The changes primarily involve updating the TinyGo version in various Makefiles to use the latest Docker image, ensuring up-to-date builds. Additionally, there are several import statement modifications across multiple Go files, with no significant alterations to function signatures or global variables.

Changes

File(s)	Summary
`example/echo/go/Makefile`, `example/tac/go/Makefile`, `testdata/.../Makefile`	Updated the TinyGo version in the build process to use the latest Docker image.
`cmd/tarmac/main.go`, `example/toolkit/main.go`, `pkg/app/...`, `pkg/callbacks/...`	Modified import statements without changing function signatures or global variables.

🐇 "In the land of code, where logic is king,

Changes come forth, updates they bring.

With Docker images fresh and new,

And import paths corrected too.

So let's hop along, no time to rest,

In our quest to make our code the best!" 🎉

Tips

Chat with CodeRabbit Bot (`@coderabbitai`)

Mention @coderabbitai in any review comment for bot assistance.
Note: Review comments are made on code diffs or files, not on the PR overview.

Pause Incremental Reviews

Insert @coderabbitai: ignore in the PR description to halt the bot's ongoing reviews. Remove the line to resume.
Additionally, enter @coderabbitai pause to halt the bot's ongoing reviews as any issue or review comment. To
resume reviews, enter @coderabbitai resume as any issue or review comment.

coderabbitai

Review Status

Actionable comments generated: 0

Commits

Files that changed from the base of the PR and between 2740a68 and db17676.

Files ignored due to filter (16)

example/echo/go/go.mod
example/echo/go/go.sum
example/tac/go/go.mod
example/tac/go/go.sum
example/toolkit/go.mod
example/toolkit/go.sum
testdata/default/go.mod
testdata/default/go.sum
testdata/function/go.mod
testdata/function/go.sum
testdata/kv/go.mod
testdata/kv/go.sum
testdata/logger/go.mod
testdata/logger/go.sum
testdata/sql/go.mod
testdata/sql/go.sum

Files selected for processing (7)

example/echo/go/Makefile (1 hunks)
example/tac/go/Makefile (1 hunks)
testdata/default/Makefile (1 hunks)
testdata/function/Makefile (1 hunks)
testdata/kv/Makefile (1 hunks)
testdata/logger/Makefile (1 hunks)
testdata/sql/Makefile (1 hunks)

Files skipped from review due to trivial changes (7)

example/echo/go/Makefile
example/tac/go/Makefile
testdata/default/Makefile
testdata/function/Makefile
testdata/kv/Makefile
testdata/logger/Makefile
testdata/sql/Makefile

coderabbitai

Review Status

Actionable comments generated: 0

Commits

Files that changed from the base of the PR and between db17676 and 7c5de8b.

Files selected for processing (12)

cmd/tarmac/main.go (1 hunks)
example/toolkit/main.go (1 hunks)
pkg/app/app.go (2 hunks)
pkg/app/app_test.go (1 hunks)
pkg/app/server.go (1 hunks)
pkg/callbacks/httpclient/httpclient.go (1 hunks)
pkg/callbacks/httpclient/httpclient_test.go (1 hunks)
pkg/callbacks/kvstore/kvstore.go (1 hunks)
pkg/callbacks/kvstore/kvstore_test.go (1 hunks)
pkg/callbacks/metrics/metrics.go (1 hunks)
pkg/callbacks/sql/sql.go (1 hunks)
pkg/callbacks/sql/sql_test.go (1 hunks)

Files skipped from review due to trivial changes (12)

cmd/tarmac/main.go
example/toolkit/main.go
pkg/app/app.go
pkg/app/app_test.go
pkg/app/server.go
pkg/callbacks/httpclient/httpclient.go
pkg/callbacks/httpclient/httpclient_test.go
pkg/callbacks/kvstore/kvstore.go
pkg/callbacks/kvstore/kvstore_test.go
pkg/callbacks/metrics/metrics.go
pkg/callbacks/sql/sql.go
pkg/callbacks/sql/sql_test.go

coderabbitai

Review Status

Actionable comments generated: 0

Commits

Files that changed from the base of the PR and between 7c5de8b and 1006d07.

Files selected for processing (1)

testdata/default/Makefile (1 hunks)

Files skipped from review due to trivial changes (1)

testdata/default/Makefile

coderabbitai

Review Status

Actionable comments generated: 0

Commits

Files that changed from the base of the PR and between 1006d07 and e464776.

Files selected for processing (1)

testdata/default/Makefile (1 hunks)

Files skipped from review due to trivial changes (1)

testdata/default/Makefile

coderabbitai · 2023-10-01T02:57:56Z

Rate Limit Exceeded

You have exceeded the limit for the number of files or commits that can be reviewed per hour. Please wait 4 minutes and 19 seconds before requesting another review.

To re-trigger a review, convert this PR to a draft and then mark it as ready for review again. Alternatively, you can push a new commit to this PR.

coderabbitai · 2023-10-01T02:59:23Z

Rate Limit Exceeded

You have exceeded the limit for the number of files or commits that can be reviewed per hour. Please wait 2 minutes and 51 seconds before requesting another review.

To re-trigger a review, convert this PR to a draft and then mark it as ready for review again. Alternatively, you can push a new commit to this PR.

coderabbitai

Review Status

Actionable comments generated: 0

Commits

Files that changed from the base of the PR and between e464776 and 2f8ba11.

Files ignored due to filter (6)

example/echo/go/go.mod
example/tac/go/go.mod
example/toolkit/go.mod
testdata/default/go.mod
testdata/function/go.mod
testdata/kv/go.mod

Files selected for processing (1)

testdata/default/Makefile (1 hunks)

Files skipped from review due to trivial changes (1)

testdata/default/Makefile

codecov · 2023-10-01T03:05:38Z

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (addf194) 82.40% compared to head (2f8ba11) 82.40%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #62    /-   ##
=======================================
  Coverage   82.40%   82.40%           
=======================================
  Files          12       12           
  Lines        1125     1125           
=======================================
  Hits          927      927           
  Misses        152      152           
  Partials       46       46

Files	Coverage Δ
pkg/app/app.go	`74.46% <ø> (ø)`
pkg/app/server.go	`77.31% <ø> (ø)`
pkg/callbacks/httpclient/httpclient.go	`72.05% <ø> (ø)`
pkg/callbacks/kvstore/kvstore.go	`84.34% <ø> (ø)`
pkg/callbacks/logging/logging.go	`100.00% <ø> (ø)`
pkg/callbacks/metrics/metrics.go	`100.00% <ø> (ø)`
pkg/callbacks/sql/sql.go	`77.10% <ø> (ø)`

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

madflojo added 2 commits September 30, 2023 17:27

Updating go mod with new location

3060be8

Updating TinyGo version

db17676

coderabbitai bot reviewed Oct 1, 2023

View reviewed changes

gofmt

7c5de8b

coderabbitai bot reviewed Oct 1, 2023

View reviewed changes

Renaming container mount

1006d07

coderabbitai bot reviewed Oct 1, 2023

View reviewed changes

That didnt work

e464776

coderabbitai bot reviewed Oct 1, 2023

View reviewed changes

Trying something

3d1a83c

Almost there

c4312d2

Reverting a bit

2f8ba11

coderabbitai bot reviewed Oct 1, 2023

View reviewed changes

madflojo merged commit df4f630 into main Oct 1, 2023
11 checks passed

madflojo deleted the updatemods branch October 1, 2023 03:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updating go mod with new location #62

Updating go mod with new location #62

madflojo commented Oct 1, 2023 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Oct 1, 2023 •

edited

Loading

Chat with CodeRabbit Bot (`@coderabbitai`)

Pause Incremental Reviews

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot commented Oct 1, 2023

coderabbitai bot commented Oct 1, 2023

coderabbitai bot left a comment

codecov bot commented Oct 1, 2023 •

edited

Loading

Updating go mod with new location #62

Updating go mod with new location #62

Conversation

madflojo commented Oct 1, 2023 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Oct 1, 2023 • edited Loading

Walkthrough

Changes

Chat with CodeRabbit Bot (@coderabbitai)

Pause Incremental Reviews

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot commented Oct 1, 2023

Rate Limit Exceeded

coderabbitai bot commented Oct 1, 2023

Rate Limit Exceeded

coderabbitai bot left a comment

Choose a reason for hiding this comment

codecov bot commented Oct 1, 2023 • edited Loading

Codecov Report

madflojo commented Oct 1, 2023 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Oct 1, 2023 •

edited

Loading

Chat with CodeRabbit Bot (`@coderabbitai`)

codecov bot commented Oct 1, 2023 •

edited

Loading