Fix error and -spec(_).s
#134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issued under OTP 22.2
Issued under OTP 22.2
Issued under OTP 22.2 This is a "double" fix: 1. it seems to me that ?error (in this case) requires string as first arg. 2. F (from the arguments) was clashing with F from the ?error macro, which caused a Guard test ... can never succeed dialyzer warning
|
@talentdeficit: do you think this PR will eventually make its way into a release? |
|
@paulo-ferraz-oliveira I'll take a look at this today. |
|
Thanks, @tsloughter. It's actually preventing proper |
tsloughter
approved these changes
Mar 12, 2020
|
Thanks, @tsloughter. Will there be a release for this? I'd prefer to work with tags instead of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The third commit (the one that took me the longest to understand, since the
dialyzermessage isn't all that clear), I had already referred to in #118 and #123, and it's finally fixed 😃The two previous commits (regarding the
module()change) had somehow not surfaced before (or I was otherwise using differentdialyzeroptions locally).I ran
rebar3 dialyzer, with no issues, on top of: